Stringify arguments and results only when logging is enabled#463
Open
isra17 wants to merge 2 commits intopython-arq:mainfrom
Open
Stringify arguments and results only when logging is enabled#463isra17 wants to merge 2 commits intopython-arq:mainfrom
isra17 wants to merge 2 commits intopython-arq:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
==========================================
+ Coverage 96.27% 96.49% +0.21%
==========================================
Files 11 11
Lines 1074 1083 +9
Branches 209 191 -18
==========================================
+ Hits 1034 1045 +11
Misses 19 19
+ Partials 21 19 -2
Continue to review full report in Codecov by Sentry.
|
Member
samuelcolvin
left a comment
samuelcolvin
left a comment
There was a problem hiding this comment.
LGTM, can you add a test.
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of our profiling profile shows that 40% of computing time is spent in
reprcall from ARQ. At the moment, even without logging this get called, which can be expensive on large inputs.